RF: move AnnexRepo.WEB_UUID constant into consts.WEB_SPECIAL_REMOTE_UUID #4460
Conversation
I'm okay with the move, but I think you should keep around the AnnexRepo attribute for compatibility (not just from a nice-to-do standpoint, but also to address the failing -container test). |
I think consts is a better place to define that alongside with other UUIDs we define for datalad special remotes. I have altogether removed WEB_UUID from AnnexRepo -- let's see if any extensions mind
|
ok, done |
The stale commit message of the first commit is likely to confuse readers, but the change itself looks okay to me.
|
oh, let's wait for green, I will reword and merge locally and push |
Sounds good, thanks. Would you mind squashing in my fixup to your first commit while you're at it? |
|
will do -- thanks! |
RF: move AnnexRepo.WEB_UUID constant into consts.WEB_SPECIAL_REMOTE_UUID: * rf-web-uuid: RF: use WEB_SPECIAL_REMOTE_UUID constant instead of hardcoded uid RF: move AnnexRepo.WEB_UUID constant into consts.WEB_SPECIAL_REMOTE_UUID
|
appveyor will be good I bet, rebased/reworded/merged/pushed as 8d6756d, closing here |
And adjust some code pieces to make use of it instead of a hardcoded value.
One questionable change was the actual move in the first commit. But since other UUIDs are defined there I thought it was reasonable.