Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: move AnnexRepo.WEB_UUID constant into consts.WEB_SPECIAL_REMOTE_UUID #4460

Closed
wants to merge 3 commits into from

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Apr 29, 2020

And adjust some code pieces to make use of it instead of a hardcoded value.

One questionable change was the actual move in the first commit. But since other UUIDs are defined there I thought it was reasonable.

@kyleam
Copy link
Collaborator

kyleam commented Apr 29, 2020

One questionable change was the actual move in the first commit. But since other UUIDs are defined there I thought it was reasonable.

I'm okay with the move, but I think you should keep around the AnnexRepo attribute for compatibility (not just from a nice-to-do standpoint, but also to address the failing -container test).

yarikoptic added 2 commits Apr 29, 2020
I think consts is a better place to define that alongside with other UUIDs
we define for datalad special remotes.  I have altogether removed WEB_UUID from
AnnexRepo -- let's see if any extensions mind
@yarikoptic
Copy link
Member Author

yarikoptic commented Apr 29, 2020

ok, done

kyleam
kyleam approved these changes Apr 29, 2020
Copy link
Collaborator

@kyleam kyleam left a comment

The stale commit message of the first commit is likely to confuse readers, but the change itself looks okay to me.

@yarikoptic
Copy link
Member Author

yarikoptic commented Apr 29, 2020

oh, let's wait for green, I will reword and merge locally and push

@yarikoptic yarikoptic self-assigned this Apr 29, 2020
@kyleam
Copy link
Collaborator

kyleam commented Apr 29, 2020

oh, let's wait for green, I will reword and merge locally and push

Sounds good, thanks. Would you mind squashing in my fixup to your first commit while you're at it?

@yarikoptic
Copy link
Member Author

yarikoptic commented Apr 29, 2020

will do -- thanks!

yarikoptic added a commit that referenced this issue Apr 29, 2020
RF: move AnnexRepo.WEB_UUID constant into consts.WEB_SPECIAL_REMOTE_UUID:

* rf-web-uuid:
  RF: use WEB_SPECIAL_REMOTE_UUID constant instead of hardcoded uid
  RF: move AnnexRepo.WEB_UUID constant into consts.WEB_SPECIAL_REMOTE_UUID
@yarikoptic
Copy link
Member Author

yarikoptic commented Apr 29, 2020

appveyor will be good I bet, rebased/reworded/merged/pushed as 8d6756d, closing here

@yarikoptic yarikoptic closed this Apr 29, 2020
@yarikoptic yarikoptic added this to the 0.13.0 milestone Apr 29, 2020
@yarikoptic yarikoptic deleted the rf-web-uuid branch May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants