Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Disable full submodule evaluation for diff(to=!None) #4549

Merged
merged 1 commit into from May 18, 2020

Conversation

mih
Copy link
Member

@mih mih commented May 17, 2020

In all such cases the comparison is made with respect to a recorded
state, so that any worktree inspection can be completely avoided.
This can lead to substantial speed-ups in large dataset hierarchies,
and helps to mitigate the needs for alternatively tailored diff
implementations, such as the one proposed in gh-4507.

In all such cases the comparison is made with respect to a recorded
state, so that any worktree inspection can be completely avoided.
This can lead to substantial speed-ups in large dataset hierarchies,
and helps to mitigate the needs for alternatively tailored `diff`
implementations, such as the one proposed in dataladgh-4507.
@mih mih added the performance label May 17, 2020
@mih mih added this to the 0.13.0 milestone May 17, 2020
@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #4549 into master will decrease coverage by 39.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4549       +/-   ##
===========================================
- Coverage   89.21%   49.97%   -39.25%     
===========================================
  Files         285      285               
  Lines       38597    38597               
===========================================
- Hits        34435    19289    -15146     
- Misses       4162    19308    +15146     
Impacted Files Coverage Δ
datalad/core/local/diff.py 94.18% <ø> (-1.17%) ⬇️
datalad/interface/run.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/clone.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/tests/test__main__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/tests/test_strings.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/tests/test_protocols.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/tests/test_addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/downloaders/tests/test_base.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/customremotes/tests/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0876e...8208fa5. Read the comment docs.

@mih mih added the merge-if-ok label May 17, 2020
kyleam
kyleam approved these changes May 18, 2020
@kyleam kyleam merged commit 2f6d655 into datalad:master May 18, 2020
10 of 12 checks passed
@mih mih deleted the enh-diff-perf branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants