BF: use '' as default (not None) while checking for a key not to be a test key #4552
… test key I just saw in https://github.com/datalad/datalad-extensions/runs/665491656?check_suite_focus=true which I believe failed for other reasons (but may be not), that there was a traceback to this line. And indeed above we might ask for a 'key' or a 'file', so hypothetically there might be no 'key' field. I have not really analyzed situation on how we have not hit it before and how it really emerges in that failure while testing against bleeding edge git annex
oh, on the most recent run https://github.com/datalad/datalad-extensions/runs/687454738?check_suite_focus=true it is the only error which causes the failure! I will try to check out what is that record now...
edit: with this fix test still would fail but differently:
so clearly something changed in git-annex behavior. heh.
FWIW the bisect pointed to the related cabbc91b1 (addurl, importfeed: Allow '-' in filenames, as long as it's not the first character, 2020-05-11). (edit: for comparison, that's 8.20200501-53-gcabbc91b1)
@@ Coverage Diff @@ ## maint #4552 +/- ## ======================================= Coverage 90.14% 90.15% ======================================= Files 275 275 Lines 37101 37099 -2 ======================================= - Hits 33446 33445 -1 + Misses 3655 3654 -1
…he filenames from urls There is also now a dedicated option to git annex addurl --preserve-filename use filename provided by server as-is to completely preserve filename.
…ases Also moved out some annex. calls outside of swallow_outputs -- we do not test them and I do not expect them to flood the screen much