Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Do not hide git-push crashes #4674

Merged
merged 1 commit into from Jul 6, 2020
Merged

BF: Do not hide git-push crashes #4674

merged 1 commit into from Jul 6, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jul 4, 2020

Previous setup assumed that any git-push error is an orderly
report that could be forensically analyzed. However, in particular
with custom remote helpers, git-push can also just crash, and
there is no guarantee that we can inspect anything.

This is a minimal change that makes sure the CommandError bubbles
up, when we know that something is fundamentally not right, because
there was an error, but the expected error message channel is empty.

In all likelihood that is still far from comprehensive, but still better
than before.

Previous setup assumed that any `git-push` error is an orderly
report that could be forensically analyzed. However, in particular
with custom remote helpers, `git-push` can also just crash, and
there is no guarantee that we can inspect anything.

This is a minimal change that makes sure the `CommandError` bubbles
up, when we know that something is fundamentally not right, because
there was an error, but the expected error message channel is empty.

In all likelihood that is still far from comprehensive, but still better
than before.
kyleam
kyleam approved these changes Jul 6, 2020
Copy link
Collaborator

@kyleam kyleam left a comment

Makes sense to me.

AppVeyor failures are due to codecov submission (gh-4670).

@kyleam kyleam merged commit 33f25c7 into datalad:maint Jul 6, 2020
9 of 10 checks passed
@mih
Copy link
Member Author

mih commented Jul 11, 2020

Thx @kyleam !

@mih mih deleted the bf-pushcrash branch Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants