Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix unpin grunt contrib qunit #4687

Merged
merged 1 commit into from Jul 10, 2020
Merged

Bugfix unpin grunt contrib qunit #4687

merged 1 commit into from Jul 10, 2020

Conversation

xgui3783
Copy link
Contributor

@xgui3783 xgui3783 commented Jul 10, 2020

This PR unpins grunt-contrib-quint dependency, allow TravisCI pulling the latest version of the aforementioned package.

Fixes #4635

Please also note, that instead of reverting to

$ npm install grunt-contrib-quint@>=2.3

This PR currently modified it to

$ npm install grunt-contrib-qunit@^4.0.0

This should install latest minor version (similar to grunt-contrib-qunit>=4.0.0 < 5.0.0), which would hopefully reduce the flakiness of tests should a major version arrives in the future.

This PR supercedes #4686

@yarikoptic
Copy link
Member

yarikoptic commented Jul 10, 2020

Thank you @xgui3783 ! looks good to me and Travis likes it too, so merging (I will also merge maint into master locally and push)

@yarikoptic yarikoptic merged commit 97d54c0 into datalad:maint Jul 10, 2020
9 of 10 checks passed
@kyleam
Copy link
Collaborator

kyleam commented Jul 10, 2020

Thanks @xgui3783!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants