Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPT: Avoid multiple calls to git-push with multiple refspecs #4692

Merged
merged 1 commit into from Jul 13, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jul 12, 2020

As noted in gh-4667, GitRepo.push() can actually do all at once.
It just claimed not to be able to. Fixed the docs, and adjusted
the call to the method in the push() command.

As noted in dataladgh-4667, `GitRepo.push()` can actually do all at once.
It just claimed not to be able to. Fixed the docs, and adjusted
the call to the method in the `push()` command.
@mih mih added documentation Documentation-related issue performance Improve performance of an existing feature labels Jul 12, 2020
Copy link
Member

@yarikoptic yarikoptic left a comment

Tests pass, so should be Ok and good to merge into maint even though not a bug fix.
I will wait for others to chime in before merging

@mih
Copy link
Member Author

mih commented Jul 13, 2020

I am not insisting on a merge into maint, hence #4693 has it too, but I thought it would be trivial enough to propose it.

kyleam
kyleam approved these changes Jul 13, 2020
@mih
Copy link
Member Author

mih commented Jul 13, 2020

Thx @yarikoptic @kyleam

@mih mih merged commit 1cb823d into datalad:maint Jul 13, 2020
9 of 10 checks passed
@mih mih deleted the maint branch Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation-related issue performance Improve performance of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants