Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Do not maintain an environment copy in GitWitlessRunner #4703

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jul 14, 2020

Instead, adjust the current environment, as needed, at the time of
each run() invocation -- like GitRunner() does it.

This avoids silently ignoring changes in the process environment
after a GitWitlessRunner instance was created.

Fixes gh-4702

I will try this out in the context of #4699, which is an ideal testbed, due to the long-running ConfigManager instance.

Instead, adjust the current environment, as needed, at the time of
each `run()` invocation -- like `GitRunner()` does it.

This avoids silently ignoring changes in the process environment
after a `GitWitlessRunner` instance was created.

Fixes dataladgh-4702
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #4703 into maint will increase coverage by 4.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4703      +/-   ##
==========================================
+ Coverage   85.22%   89.60%   +4.37%     
==========================================
  Files         288      288              
  Lines       39106    40172    +1066     
==========================================
+ Hits        33329    35995    +2666     
+ Misses       5777     4177    -1600     
Impacted Files Coverage Δ
datalad/cmd.py 90.07% <100.00%> (+0.31%) ⬆️
datalad/support/tests/test_vcr_.py 57.89% <0.00%> (-3.22%) ⬇️
datalad/distributed/tests/ria_utils.py 44.73% <0.00%> (-1.21%) ⬇️
datalad/support/vcr_.py 49.12% <0.00%> (-0.88%) ⬇️
datalad/support/digests.py 100.00% <0.00%> (ø)
datalad/tests/test_base.py 100.00% <0.00%> (ø)
datalad/tests/test__main__.py 100.00% <0.00%> (ø)
datalad/ui/tests/test_base.py 100.00% <0.00%> (ø)
datalad/tests/test_protocols.py 100.00% <0.00%> (ø)
datalad/tests/test_dochelpers.py 100.00% <0.00%> (ø)
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547acd9...aa1e15d. Read the comment docs.

Copy link
Contributor

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do any testing on my end, but the problem description and proposed fix make sense to me.

@mih
Copy link
Member Author

mih commented Jul 14, 2020

Thx!

@mih mih merged commit 2036712 into datalad:maint Jul 14, 2020
@mih mih deleted the bf-4702 branch July 14, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants