Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Readable SSH error messages #4729

Merged
merged 1 commit into from Jul 15, 2020
Merged

BF: Readable SSH error messages #4729

merged 1 commit into from Jul 15, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jul 15, 2020

Do not stringify what doesn't need to be -- we have more clever
rendering now, than we had when this was written.

Turns

ConnectionOpenFailedError: ''['"'"'ssh'"'"', '"'"'-fN'"'"', '"'"'-o'"'"', '"'"'ControlMaster=auto'"'"', '"'"'-o'"'"', '"'"'ControlPersist=15m'"'"', '"'"'-o'"'"', '"'"'ControlPath=/media/mih/Samsung_T5/tmp/datalad_temp_ml_70qcw/.cache/datalad/sockets/6258b3a7'"'"', '"'"'localhost'"'"']'' failed with exitcode 255 [Failed to open SSH connection (could not start ControlMaster process)]']

into

ConnectionOpenFailedError: 'ssh -fN -o ControlMaster=auto -o ControlPersist=15m -o ControlPath=/media/mih/Samsung_T5/tmp/datalad_temp_01cz4bxi/.cache/datalad/sockets/6258b3a7 localhost' failed with exitcode 255 [Failed to open SSH connection (could not start ControlMaster process)]']

Do not stringify what doesn't need to be -- we have more clever
rendering now, than we had when this was written.

Turns

```
ConnectionOpenFailedError: ''['"'"'ssh'"'"', '"'"'-fN'"'"', '"'"'-o'"'"', '"'"'ControlMaster=auto'"'"', '"'"'-o'"'"', '"'"'ControlPersist=15m'"'"', '"'"'-o'"'"', '"'"'ControlPath=/media/mih/Samsung_T5/tmp/datalad_temp_ml_70qcw/.cache/datalad/sockets/6258b3a7'"'"', '"'"'localhost'"'"']'' failed with exitcode 255 [Failed to open SSH connection (could not start ControlMaster process)]']
```

into

```
ConnectionOpenFailedError: 'ssh -fN -o ControlMaster=auto -o ControlPersist=15m -o ControlPath=/media/mih/Samsung_T5/tmp/datalad_temp_01cz4bxi/.cache/datalad/sockets/6258b3a7 localhost' failed with exitcode 255 [Failed to open SSH connection (could not start ControlMaster process)]']
```
@mih mih added the UX user experience label Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #4729 into maint will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4729      +/-   ##
==========================================
+ Coverage   89.51%   89.58%   +0.06%     
==========================================
  Files         288      288              
  Lines       40177    40177              
==========================================
+ Hits        35965    35991      +26     
+ Misses       4212     4186      -26     
Impacted Files Coverage Δ
datalad/support/sshconnector.py 85.90% <ø> (ø)
datalad/support/gitrepo.py 90.37% <0.00%> (-0.08%) ⬇️
datalad/tests/test_utils.py 95.60% <0.00%> (+0.27%) ⬆️
datalad/support/tests/test_annexrepo.py 96.73% <0.00%> (+0.37%) ⬆️
datalad/core/local/tests/test_save.py 97.96% <0.00%> (+0.45%) ⬆️
datalad/tests/test_log.py 99.08% <0.00%> (+0.91%) ⬆️
datalad/interface/tests/test_unlock.py 97.91% <0.00%> (+2.08%) ⬆️
datalad/log.py 86.09% <0.00%> (+6.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b684c...66dee3e. Read the comment docs.

@yarikoptic yarikoptic merged commit 3ae696c into datalad:maint Jul 15, 2020
12 checks passed
@mih mih deleted the bf-sshexc branch Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants