Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Error handling when magic Dataset identifiers '^' and '^.' do not resolve #4759

Merged
merged 1 commit into from Jul 22, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jul 22, 2020

Raise NoDatasetFound exception immediately, instead of letting
subsequent code fail in cryptic ways.

Fixes gh-4758

… resolve

Raise `NoDatasetFound` exception immediately, instead of letting
subsequent code fail in cryptic ways.

Fixes dataladgh-4758
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #4759 into maint will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4759      +/-   ##
==========================================
+ Coverage   89.42%   89.56%   +0.13%     
==========================================
  Files         288      288              
  Lines       40196    40204       +8     
==========================================
+ Hits        35947    36010      +63     
+ Misses       4249     4194      -55     
Impacted Files Coverage Δ
datalad/distribution/dataset.py 94.42% <100.00%> (+0.09%) ⬆️
datalad/distribution/tests/test_dataset.py 99.67% <100.00%> (+<0.01%) ⬆️
datalad/downloaders/http.py 82.74% <0.00%> (-2.75%) ⬇️
datalad/downloaders/tests/test_http.py 87.71% <0.00%> (-2.22%) ⬇️
datalad/distribution/create_sibling.py 85.02% <0.00%> (ø)
datalad/support/tests/test_annexrepo.py 96.58% <0.00%> (+<0.01%) ⬆️
datalad/utils.py 81.92% <0.00%> (+0.09%) ⬆️
datalad/tests/test_cmd.py 97.48% <0.00%> (+0.50%) ⬆️
datalad/core/local/create.py 94.44% <0.00%> (+0.69%) ⬆️
datalad/tests/utils_testrepos.py 94.06% <0.00%> (+0.84%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b36603...ff6f7ea. Read the comment docs.

kyleam
kyleam approved these changes Jul 22, 2020
Copy link
Collaborator

@kyleam kyleam left a comment

Looks good to me. Thanks.

@yarikoptic yarikoptic merged commit 0876697 into datalad:maint Jul 22, 2020
4 checks passed
@mih mih deleted the bf-4758 branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants