Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: create GitHub sibling as private repo #4769

Merged
merged 5 commits into from Jul 29, 2020

Conversation

nicholsn
Copy link
Contributor

Overview

This PR adds a new --private flag to the datalad create-sibling-github command that result in a GitHub repo being created that is only viewable by members that have been given access.

How it was tested

Created both public and private repositories successfully using the following

datalad create-sibling-github --github-organization $TEST --access-protocol ssh --name $TEST --private $TEST

mih
mih previously approved these changes Jul 28, 2020
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the patch!

@mih mih self-requested a review July 28, 2020 07:03
@mih mih dismissed their stale review July 28, 2020 07:03

Submitted too early

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the patch! From the test failures it seems as if some test code still needs to be adjusted for the introduction of a new positional arg.

@nicholsn nicholsn changed the title Nf create GitHub sibling as private repo NF: create GitHub sibling as private repo Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #4769 into master will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4769      +/-   ##
==========================================
- Coverage   89.64%   89.53%   -0.11%     
==========================================
  Files         287      287              
  Lines       40219    40237      +18     
==========================================
- Hits        36056    36028      -28     
- Misses       4163     4209      +46     
Impacted Files Coverage Δ
datalad/distribution/create_sibling_github.py 83.87% <ø> (ø)
datalad/support/github_.py 78.65% <100.00%> (ø)
datalad/support/tests/test_github_.py 87.50% <100.00%> (+0.17%) ⬆️
datalad/log.py 79.37% <0.00%> (-6.73%) ⬇️
datalad/downloaders/http.py 82.74% <0.00%> (-2.75%) ⬇️
datalad/core/local/tests/test_status.py 96.33% <0.00%> (-2.59%) ⬇️
datalad/downloaders/tests/test_http.py 87.71% <0.00%> (-2.22%) ⬇️
datalad/interface/tests/test_unlock.py 95.83% <0.00%> (-2.09%) ⬇️
datalad/tests/test_log.py 98.16% <0.00%> (-0.92%) ⬇️
datalad/core/local/tests/test_save.py 97.51% <0.00%> (-0.46%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6908a01...03ef066. Read the comment docs.

@nicholsn
Copy link
Contributor Author

@mih thanks! Updated the test to pass, but now coverage is "failing"... what do you suggest?

@mih
Copy link
Member

mih commented Jul 29, 2020

Thanks! IMHO the loss of coverage isn't too terrible in this case.

@kyleam
Copy link
Contributor

kyleam commented Jul 29, 2020

Looks good to me too. Thanks @nicholsn.

@kyleam kyleam merged commit 6f0e488 into datalad:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants