Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Remove legacy API from config manager #4828

Merged
merged 1 commit into from Aug 22, 2020
Merged

Conversation

mih
Copy link
Member

@mih mih commented Aug 22, 2020

The dataset_only option was deprecated with the release of 0.12, and
can be removed with the release of 0.14.

The `dataset_only` option was deprecated with the release of 0.12, and
can be removed with the release of 0.14.
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis fail seems unrelated

......S........
======================================================================
ERROR: datalad.support.tests.test_annexrepo.test_AnnexRepo_commit
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/datalad/tests/utils.py", line 1188, in newfunc
    raise exc_info[1]
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/datalad/tests/utils.py", line 1160, in newfunc
    ret = func(*args, **kwargs)
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/datalad/tests/utils.py", line 731, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/datalad/support/tests/test_annexrepo.py", line 784, in test_AnnexRepo_commit
    assert_raises(FileNotInRepositoryError, ds.commit, files="untracked")
  File "/opt/python/3.5.6/lib/python3.5/unittest/case.py", line 733, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/opt/python/3.5.6/lib/python3.5/unittest/case.py", line 178, in handle
    callable_obj(*args, **kwargs)
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/datalad/support/gitrepo.py", line 1671, in commit
    stdin=None,
  File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/datalad/cmd.py", line 504, in run
    **results,
datalad.support.exceptions.CommandError: CommandError: 'git commit -m '[DATALAD] Recorded changes' -- untracked' failed with exitcode 1 under /tmp/datalad_temp_test_AnnexRepo_commit9o8tma8w

@mih
Copy link
Member Author

mih commented Aug 22, 2020

Thx @yarikoptic

@mih mih merged commit 8df3106 into datalad:master Aug 22, 2020
@mih mih deleted the rf-config branch July 19, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants