Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: replace wrapped "new_?func" with meaningful "_wrap_<wrappedfunction>" #4834

Merged
merged 1 commit into from Aug 27, 2020

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Aug 26, 2020

All the generators and "newfunc"s in the traceback complicate
troubleshooting etc. I think we got used to this bad practice and
should abandon it and give wrapped functions names reflecting of the
decorator name. I chose _wrap_, since first I chose just _ and
ran into a conflict interfering with outside _normalize_path.
So decided to be more explicit.

If someone now gives me a one liner which could have just been used, my pride will be scarred forever!

…on>"

All the generators and "newfunc"s in the traceback complicate
troubleshooting etc.  I think we got used to this bad practice and
should abandon it and give wrapped functions names reflecting of the
decorator name.  I chose `_wrap_`, since first I chose just `_` and
ran into a conflict interfering with outside `_normalize_path`.
So decided to be more explicit
@yarikoptic yarikoptic added the UX user experience label Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #4834 into maint will decrease coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4834      +/-   ##
==========================================
- Coverage   89.67%   89.61%   -0.06%     
==========================================
  Files         288      288              
  Lines       40371    40371              
==========================================
- Hits        36203    36180      -23     
- Misses       4168     4191      +23     
Impacted Files Coverage Δ
datalad/distributed/tests/ria_utils.py 44.73% <0.00%> (ø)
datalad/utils.py 81.92% <0.00%> (ø)
datalad/tests/utils.py 87.15% <91.66%> (ø)
datalad/distributed/ora_remote.py 30.95% <100.00%> (ø)
...talad/distributed/tests/test_create_sibling_ria.py 100.00% <100.00%> (ø)
datalad/support/gitrepo.py 90.40% <100.00%> (-0.08%) ⬇️
datalad/tests/test_utils.py 95.59% <100.00%> (ø)
datalad/tests/utils_cached_dataset.py 92.59% <100.00%> (ø)
datalad/support/tests/test_cookies.py 86.66% <0.00%> (-13.34%) ⬇️
datalad/downloaders/http.py 81.85% <0.00%> (-2.71%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad7bc7...4239825. Read the comment docs.

kyleam
kyleam approved these changes Aug 27, 2020
@yarikoptic yarikoptic merged commit fa65867 into datalad:maint Aug 27, 2020
2 of 4 checks passed
@yarikoptic yarikoptic deleted the enh-newfunc branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants