addurls: Support tsv input #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test gives "not_csv_or_json" as invalid input to extract(), but, if we were to stick with that scheme, an upcoming commit would have to change it to "not_csv_or_tsv_or_json".
This trims a few spots that we'd need to update when tsv support is added. Using the new variable in test_addurls_invalid_input means we also test "ext", which is a good thing.
Make it easier to plug tsv input into these spots.
To read tab-separated input, the core functional change needed is specifying tab as the delimiter to csv.reader(). The rest is a matter of updating the documentation and the handling of the input_type argument. Closes datalad#4839.
Codecov Report
@@ Coverage Diff @@
## master #4845 +/- ##
==========================================
+ Coverage 89.66% 89.70% +0.04%
==========================================
Files 289 289
Lines 40461 40473 +12
==========================================
+ Hits 36279 36308 +29
+ Misses 4182 4165 -17
Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Requested in gh-4839.