Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Require Python >=3.6 #4879

Merged
merged 2 commits into from Sep 7, 2020
Merged

RF: Require Python >=3.6 #4879

merged 2 commits into from Sep 7, 2020

Conversation

mih
Copy link
Member

@mih mih commented Sep 6, 2020

PY35 will come to its end-of-life (EOL) in a week from now.

https://devguide.python.org/#status-of-python-branches

Fixes gh-4878

TODO

  • Can more travis runs be stripped?
  • Scan the code base to remove PY35 compatibility kludges

PY35 will come to its end-of-life (EOL) in a week from now.

https://devguide.python.org/#status-of-python-branches

Fixes dataladgh-4878
@mih mih added the conference agenda item Scheduled to be discussed in a developer meeting label Sep 6, 2020
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #4879 into master will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4879      +/-   ##
==========================================
+ Coverage   89.36%   89.72%   +0.35%     
==========================================
  Files         289      289              
  Lines       39587    40655    +1068     
==========================================
+ Hits        35377    36477    +1100     
+ Misses       4210     4178      -32     
Impacted Files Coverage Δ
datalad/utils.py 82.34% <100.00%> (+0.19%) ⬆️
datalad/support/tests/test_vcr_.py 57.89% <0.00%> (-3.22%) ⬇️
datalad/interface/tests/test_unlock.py 95.87% <0.00%> (-1.98%) ⬇️
datalad/distributed/tests/ria_utils.py 44.73% <0.00%> (-1.21%) ⬇️
datalad/support/vcr_.py 49.12% <0.00%> (-0.88%) ⬇️
datalad/tests/utils.py 87.15% <0.00%> (-0.15%) ⬇️
datalad/support/digests.py 100.00% <0.00%> (ø)
datalad/tests/test_base.py 100.00% <0.00%> (ø)
datalad/downloaders/shub.py 100.00% <0.00%> (ø)
datalad/tests/test_config.py 100.00% <0.00%> (ø)
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105e1ff...b0cf49c. Read the comment docs.

@mih mih mentioned this pull request Sep 6, 2020
@mih mih marked this pull request as ready for review September 6, 2020 07:45
@yarikoptic yarikoptic merged commit 99ad2be into datalad:master Sep 7, 2020
@mih
Copy link
Member Author

mih commented Sep 7, 2020

I thought we talk about it in the call tomorrow and weigh the pros and cons... Only pros then ;-)

🏃🏂🏄⛷️🏇

@mih mih deleted the rf-minpy36 branch September 7, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conference agenda item Scheduled to be discussed in a developer meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set minimum Python version to 3.6?
3 participants