New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF: Make archive (de)compression use WitlessRunner #4900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4900 +/- ##
==========================================
- Coverage 89.80% 89.76% -0.04%
==========================================
Files 289 289
Lines 40659 40657 -2
==========================================
- Hits 36512 36494 -18
- Misses 4147 4163 +16
Continue to review full report at Codecov.
|
datalad/support/archive_utils_7z.py
Outdated
else: | ||
# fire and forget | ||
cmd = ['7z', 'x', archive] | ||
runner.run(cmd) | ||
runner.run(cmd, protocol=StdOutErrCapture) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this function and the one below aren't returning the output, would it be better to use the KillOutput
protocol?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. You are absolutely correct!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Discarded the Runner output.
Thanks for the review @kyleam. I made the switch to |
Hm. I'm aware that it passed here, but since it only started now, seems related to this merge. |
Another small step.
Went for a dedicated subshell to implement the pipe, rather than an exploration how to connect two runners. Not worse than what it was before.