Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire some compatibility kludges #4904

Merged
merged 7 commits into from Sep 16, 2020
Merged

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Sep 8, 2020

No description provided.

@kyleam
Copy link
Contributor Author

kyleam commented Sep 8, 2020

The no_annex change needs further work.

@kyleam kyleam marked this pull request as draft September 8, 2020 18:05
@kyleam kyleam marked this pull request as ready for review September 8, 2020 18:29
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #4904 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4904      +/-   ##
==========================================
- Coverage   89.80%   89.79%   -0.01%     
==========================================
  Files         289      289              
  Lines       40659    40700      +41     
==========================================
+ Hits        36512    36547      +35     
- Misses       4147     4153       +6     
Impacted Files Coverage Δ
datalad/core/distributed/tests/test_clone.py 94.21% <ø> (+0.11%) ⬆️
datalad/core/local/create.py 93.05% <ø> (-1.39%) ⬇️
datalad/support/annexrepo.py 88.99% <ø> (-0.02%) ⬇️
datalad/support/gitrepo.py 90.19% <ø> (+0.77%) ⬆️
...talad/distributed/tests/test_create_sibling_ria.py 100.00% <100.00%> (ø)
datalad/support/tests/test_gitrepo.py 99.77% <100.00%> (+<0.01%) ⬆️
datalad/downloaders/http.py 81.85% <0.00%> (-2.71%) ⬇️
datalad/downloaders/tests/test_http.py 87.71% <0.00%> (-2.22%) ⬇️
datalad/utils.py 82.29% <0.00%> (-0.06%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8fe6e...1071d0f. Read the comment docs.

@kyleam kyleam added the do not merge Not to be merged, will trigger WIP app "not passed" status label Sep 8, 2020
This location was marked as obsolete in v0.12.0.
This has been unused since v0.12.6, specifically 8d75a66 (RF: Make
default number of annex jobs configurable and 1 by default,
2020-04-17).
This parameter was added in v0.12 to give callers time to adjust to
the changes from bea8551 (RF: gitrepo: Rewrite get_submodules() to
avoid GitPython, 2019-07-30).
We no longer have any callers for get_submodules() in our code base.
If we're going to keep it around, there should at least be a simple
check that it works.
@kyleam
Copy link
Contributor Author

kyleam commented Sep 15, 2020

That PR was merged (thanks @mih). I've updated this PR to not drop no_annex, instead adjusting the nearby comment to mention that no_annexs removal depends on a -metalad release.

range-diff
1:  516eb7d9f = 1:  516eb7d9f DOC: create: Adjust documentation for no_annex deprecation
2:  5f77c9744 = 2:  5f77c9744 MNT: Drop use of create's deprecated no_annex parameter
3:  0e6ff8760 < -:  --------- MNT: create: Drop no_annex parameter
-:  --------- > 3:  6f11d2d35 MNT: create: Update to-do note about no_annex removal
4:  332a31451 = 4:  77f6ba9d3 MNT: Drop distribution.clone shim
5:  092ff4cb9 = 5:  b8daf6ef8 MNT: annexrepo: Drop N_AUTO_JOBS
6:  6d553f2f0 = 6:  691c38210 MNT: gitrepo.get_submodules: Drop compat parameter
7:  9934b66b2 = 7:  1071d0ffa TST: gitrepo: Add basic test for get_submodules()

@kyleam kyleam removed the do not merge Not to be merged, will trigger WIP app "not passed" status label Sep 15, 2020
@yarikoptic yarikoptic merged commit dc8f781 into datalad:master Sep 16, 2020
@kyleam
Copy link
Contributor Author

kyleam commented Sep 16, 2020

@yarikoptic Thanks for the review/merge.

@kyleam kyleam deleted the prune-obsolete branch September 16, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants