Deprecate datalad.utils.assure_* aliases #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataladgh-3909 renamed each assure_* function in datalad.utils to use ensure_, assigning the new names to the old ones for compatibility. We use the assure_ variants widely throughout our code base. At that time, we decided to temporarily let those occurrences be to avoid merge conflicts. Do that bulk replacement now. Note that there are still a couple of assure_ methods in the code base. Those are left to another series, if someone thinks those are worth cleaning up.
The bulk s/assure_*/ensure_*/ from the last commit didn't adjust import order. Fix the cases where it looks like things were ordered and the last commit messed it up.
In 0.12.0, all of the assure_* functions in datalad.utils were renamed as ensure_*, keeping the old names around as compatibility aliases. Now that we don't use any of the old names in our code base, deprecate them so the we can remove them in a later release. Re: datalad#3779
Codecov Report
@@ Coverage Diff @@
## master #4908 +/- ##
==========================================
- Coverage 89.80% 89.50% -0.30%
==========================================
Files 289 289
Lines 40659 40667 +8
==========================================
- Hits 36512 36400 -112
- Misses 4147 4267 +120
Continue to review full report at Codecov.
|
|
-container failure is the test_schemes failure that recently popped up (datalad/datalad-container#126). |
yarikoptic
approved these changes
Sep 8, 2020
|
Thx! 🇬🇧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series follows up on gh-3909, removing all uses of
datalad.utils.assure_*functions from the code base and then marking the functions as deprecated.