ENH: create-sibling-github --existing=replace #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## maint #5008 +/- ##
==========================================
- Coverage 89.91% 89.89% -0.03%
==========================================
Files 292 292
Lines 40736 40755 +19
==========================================
+ Hits 36629 36636 +7
- Misses 4107 4119 +12
Continue to review full report at Codecov.
|
kyleam
reviewed
Oct 13, 2020
I wanted this feature on multiple occasions, primarily during testing. It is not a default mode, and in a leaf command so I thought it is ok to keep it against maint
…ss interactive) Also adjusted doc for the option to match the one for create-sibling
… raise exception thanks @kyleam for spotting that
kyleam
approved these changes
Oct 13, 2020
|
thank you @kyleam for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I created a reproducer for #4997 and wanted to look into "default branch" situation, so positioned on top of maint, but really wanted automation to help deleting test repo from github, so derailed into this one. I am ok to rebase for master if deemed desired.