Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: create-sibling-github --existing=replace #5008

merged 3 commits into from Oct 15, 2020


Copy link

I created a reproducer for #4997 and wanted to look into "default branch" situation, so positioned on top of maint, but really wanted automation to help deleting test repo from github, so derailed into this one. I am ok to rebase for master if deemed desired.

Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #5008 into maint will decrease coverage by 0.02%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5008      +/-   ##
- Coverage   89.91%   89.89%   -0.03%     
  Files         292      292              
  Lines       40736    40755      +19     
+ Hits        36629    36636       +7     
- Misses       4107     4119      +12     
Impacted Files Coverage Δ
datalad/distribution/ 85.59% <ø> (ø)
datalad/distribution/ 83.87% <ø> (ø)
datalad/support/ 73.82% <13.33%> (-4.83%) ⬇️
datalad/support/ 86.84% <0.00%> (ø)
datalad/core/local/ 98.71% <0.00%> (+0.01%) ⬆️
datalad/core/local/tests/ 98.77% <0.00%> (+0.01%) ⬆️
datalad/cmdline/ 77.14% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d071bcd...37407f0. Read the comment docs.

Copy link

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a cursory look, the overall logic looks fine to me.

datalad/support/ Outdated Show resolved Hide resolved
datalad/distribution/ Outdated Show resolved Hide resolved
I wanted this feature on multiple occasions, primarily during testing.
It is not a default mode, and in a leaf command so I thought it is ok
to keep it against maint
…ss interactive)

Also adjusted doc for the option to match the one for create-sibling
Copy link
Member Author

thank you @kyleam for the review

@yarikoptic yarikoptic merged commit c4cd70c into datalad:maint Oct 15, 2020
2 of 4 checks passed
@yarikoptic yarikoptic deleted the bf-gh branch October 19, 2020 22:59
@yarikoptic yarikoptic added this to the 0.13.5 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants