BF: always save run sidecar files #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reveals a bug in datalad-run, where sidecar files are not committed, when outputs are specified w/ --explicit.
bpoldrack
force-pushed
the
fix-run-sidecar
branch
from
2841fe7
to
4afd3d0
Compare
Codecov Report
@@ Coverage Diff @@
## maint #5017 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 292 292
Lines 40736 40741 +5
=======================================
+ Hits 36629 36634 +5
Misses 4107 4107
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix a bug in
datalad-run, where sidecar files weren't saved, when outputs are specified w/--explicit.A caller of
runcan't know the to be saved path and shouldn't need to care for a builtin feature to be functional. Can't see an argument why this wouldn't be a bug.