Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: always save run sidecar files #5017

merged 2 commits into from Oct 12, 2020


Copy link

Fix a bug in datalad-run, where sidecar files weren't saved, when outputs are specified w/ --explicit.
A caller of run can't know the to be saved path and shouldn't need to care for a builtin feature to be functional. Can't see an argument why this wouldn't be a bug.

This reveals a bug in datalad-run, where
sidecar files are not committed, when outputs
are specified w/ --explicit.
@bpoldrack bpoldrack changed the base branch from master to maint October 12, 2020 10:43
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #5017 into maint will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            maint    #5017   +/-   ##
  Coverage   89.91%   89.91%           
  Files         292      292           
  Lines       40736    40741    +5     
+ Hits        36629    36634    +5     
  Misses       4107     4107           
Impacted Files Coverage Δ
datalad/core/local/ 98.71% <100.00%> (+0.01%) ⬆️
datalad/core/local/tests/ 98.77% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d071bcd...4afd3d0. Read the comment docs.

Copy link

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bpoldrack.

@bpoldrack bpoldrack merged commit a55baf6 into datalad:maint Oct 12, 2020
4 checks passed
@yarikoptic yarikoptic added this to the 0.13.5 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants