Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: indi-s3 credentials #5045

merged 1 commit into from Oct 15, 2020


Copy link

@loj loj commented Oct 15, 2020

The datalad-test-s3 credentials are configured as the default for indi-s3, which prevents the ability to connect anonymously. This change fixes #5038

Copy link

thanks! but you should have started from maint branch. The easiest way imho would be to close this PR, then

git fetch origin
git checkout -b bf-indis3-credentials2 origin/maint
git cherry-pick bf-indis3-credentials
git branch -D bf-indis3-credentials

and then submit a PR ;) of cause there is also without closing this PR but "fixing it up":

git checkout bf-indis3-credentials
git fetch origin
git  reset --hard origin/maint
git cherry-pick 014d0c418699217fdddd47577f30fbd7af28ae06
git push -f

and of cause there is also git rebase but I will leave that one out for now ;)

Copy link
Collaborator Author

loj commented Oct 15, 2020

Oops, sorry about that. Thanks for the instructions for fixing it up. :-) I think it's right now.

Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #5045 into maint will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            maint    #5045   +/-   ##
  Coverage   89.93%   89.93%           
  Files         292      292           
  Lines       40756    40756           
  Hits        36652    36652           
  Misses       4104     4104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cd70c...0f15efd. Read the comment docs.

@yarikoptic yarikoptic merged commit 605a995 into datalad:maint Oct 15, 2020
4 checks passed
@yarikoptic yarikoptic added this to the 0.13.5 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants