BF: push - do not call localsync unless annex #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered by chance while troubleshooting failing datalad#5022 which due to "out of order" completion of get swapped datasets between noannex and annexed. Was fund to debug .... heh ;)
Codecov Report
@@ Coverage Diff @@
## maint #5051 +/- ##
==========================================
- Coverage 89.94% 89.90% -0.04%
==========================================
Files 292 292
Lines 40834 40838 +4
==========================================
- Hits 36727 36716 -11
- Misses 4107 4122 +15
Continue to review full report at Codecov.
|
yarikoptic
added
the
merge-if-ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by chance while troubleshooting failing
#5022
which due to "out of order" completion of get swapped datasets between
noannex and annexed. Was fund to debug (so added descriptive temp dirs suffixes) .... heh ;)
While at it spotted unused kwarg in
_push. Removed - no need to keep and must not break anything