Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH pbar + typo fix #5057

Merged
merged 2 commits into from Oct 20, 2020
Merged

ENH pbar + typo fix #5057

merged 2 commits into from Oct 20, 2020

Conversation

yarikoptic
Copy link
Member

ENH(UX): make tqdm react on changes in the terminal width

Discovered in https://github.com/tqdm/tqdm/issues/631 and version identified via

    $> git describe --contains 1392025c4948f44ad6f2befc3a26b0403732abae
    v2.1.0^2~3

verified to work quite nicely on a parallel addurls example (see #5022)

Discovered in tqdm/tqdm#631 and version identified via

    $> git describe --contains 1392025c4948f44ad6f2befc3a26b0403732abae
    v2.1.0^2~3

verified to work quite nicely on a parallel addurls example (see datalad#5022)
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #5057 into maint will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            maint    #5057   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         292      292           
  Lines       40861    40863    +2     
=======================================
+ Hits        36759    36761    +2     
  Misses       4102     4102           
Impacted Files Coverage Δ
datalad/support/gitrepo.py 90.67% <ø> (ø)
datalad/ui/progressbars.py 78.03% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d7ee3d...f8ae55d. Read the comment docs.

@yarikoptic
Copy link
Member Author

Thank you @kyleam, I will proceed then

@yarikoptic yarikoptic merged commit 39939f1 into datalad:maint Oct 20, 2020
@yarikoptic yarikoptic added this to the 0.13.5 milestone Dec 12, 2020
@yarikoptic yarikoptic deleted the en-pbar branch April 29, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants