OPT: Rate limit result suppression message update #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating it for each result is the cause of the slow-down reported in datalad#4868 (comment) With this change we only update at max 2Hz. For the original scenario this results in a ~30% speed-up: ``` datalad subdatasets -d . 4.30s user 1.99s system 101% cpu 6.225 total datalad subdatasets -d . 6.33s user 2.27s system 100% cpu 8.538 total ```
mih
added
performance
3 tasks
kyleam
reviewed
Oct 21, 2020
| @@ -514,16 +515,24 @@ def default_result_renderer(res): | |||
| if res.get('message', None) else '')) | |||
|
|
|||
|
|
|||
| def _display_suppressed_message(nsimilar, ndisplayed, final=False): | |||
| def _display_suppressed_message(nsimilar, ndisplayed, last_ts, final=False): | |||
There was a problem hiding this comment.
This direction sounds good to me, but I guess that the rate-limiting shouldn't be in effect when final=True?
yarikoptic
reviewed
Oct 21, 2020
Codecov Report
@@ Coverage Diff @@
## maint #5060 +/- ##
=======================================
Coverage 89.96% 89.96%
=======================================
Files 292 292
Lines 40863 40875 +12
=======================================
+ Hits 36761 36774 +13
+ Misses 4102 4101 -1
Continue to review full report at Codecov.
|
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Even if it is triggered faster than the rate limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Updating it for each result is the cause of the slow-down reported in
#4868 (comment)
With this change we only update at max 2Hz. For the original scenario
this results in a ~30% speed-up: