Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: addurl - store original urlfile, not resolved full path #5091

Merged
merged 1 commit into from Oct 26, 2020

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Oct 24, 2020

Rationale - to make commit message "portable" happen someone needs to
redo it. Ideally the urlfile should be either "-" or relative within dataset
path. I decided to not inforce it but merely store the original specification
of the user.

Also decided to just adjust/reuse existing test to not add more time to setup
a dedicated one

NB positioned against master since changes the record/behavior, unless there is consensus that it is appropriate for maint ;)

Rationale - to make commit message "portable" happen someone needs to
redo it. Ideally the urlfile should be either "-" or relative within dataset
path.  I decided to not inforce it but merely store the original specification
of the user.

Also decided to just adjust/reuse existing test to not add more time to setup
a dedicated one
@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #5091 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5091   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files         293      293           
  Lines       41272    41274    +2     
=======================================
+ Hits        37073    37075    +2     
  Misses       4199     4199           
Impacted Files Coverage Δ
datalad/plugin/addurls.py 99.72% <ø> (ø)
datalad/plugin/tests/test_addurls.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aba263...60547c2. Read the comment docs.

@yarikoptic yarikoptic merged commit 635b6af into datalad:master Oct 26, 2020
4 checks passed
@yarikoptic yarikoptic deleted the enh-addurls-relpath branch April 29, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants