Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Prevent Repo to resolve network mount to UNC paths on windows #5113

Merged
merged 1 commit into from Nov 3, 2020

Conversation

mih
Copy link
Member

@mih mih commented Nov 2, 2020

Fixes gh-5112

No idea how to programatically create a network mount on appveyor, hence fixing without a test for now. Left extensive note to prevent accidental removal.

@mih
Copy link
Member Author

mih commented Nov 2, 2020

Appveyor timed out.

kyleam
kyleam approved these changes Nov 2, 2020
@kyleam
Copy link
Collaborator

kyleam commented Nov 2, 2020

Appveyor timed out.

I guess this might start to be a somewhat regular annoyance after gh-5080 :/ Should we split tests across the runs?

@yarikoptic
Copy link
Member

or just switch from appveyor to github actions? although split might be easier ATM and in particular for maint

@mih
Copy link
Member Author

mih commented Nov 3, 2020

or just switch from appveyor to github actions? although split might be easier ATM and in particular for maint

We have used github actions rather unsuccessfully in the past. Primary reason for that is that they are a bitch to debug and behave even more different from a real win10 box than appveyor. I.e. placement of files across drives #5116.

I am not saying that those are not worth fixing, but moving to github action doesn't yield passing tests per se.

@mih
Copy link
Member Author

mih commented Nov 3, 2020

Thx for the review @kyleam

@mih mih merged commit 937a95c into datalad:maint Nov 3, 2020
1 of 2 checks passed
@mih mih deleted the bf-5112 branch November 3, 2020 11:55
@yarikoptic
Copy link
Member

FWIW

I.e. placement of files across drives #5116.

like it could happen in real life , so IMHO only a + . debugging is a b.tch indeed.
But if we get setup consistent so could be reproduced locally - so far I think I was able to reproduce windows issues I saw on github actions in a local VM.
FWIW, https://github.com/datalad/git-annex/pull/7/files (after git-annex stops to FTBFS) provides workflows for all OSes, and will be merged and later extended to run datalad tests on windows as well. As on Linux and OSX the target will be version: [master, maint, release] for datalad. It would be nice to workout a way to avoid code duplication and "absorb" datalad testing specific components of that workflow also here, or in general look how we could harmonize/centralize "test datalad" github actions between that repository and this one (here - against our "base" git-annex version, there - against freshly built).

@yarikoptic yarikoptic added this to the 0.13.6 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants