Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: workarounds to tests on Windows #5119

merged 4 commits into from Nov 3, 2020


Copy link

No real fixes since should be done either on git-annex level (misbehaving locking when path is too long) or us RFing tests to rely on capabilities of the TMPDIR instead of if on_windows, so might even start failing where was working before.

BUT with today's git-annex (soon to be built on CRON job, will upload to packages/ tomorrow) datalad/customremotes/tests/ tests all pass for me on windows VM.

also I gift you the mighty which you might love in a moment of despair.


We are looking into the future and upon the flagman Windows 10.  Test was failing for me
due to assumptions of the past (or whatever).  Anyways -- we should have first tested
 TMPDIR file system capabilities and conditioned based on that instead of which OS we are running
@yarikoptic yarikoptic added the platform-windows Issue concerned with Windows label Nov 3, 2020
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #5119 into maint will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5119      +/-   ##
+ Coverage   89.70%   89.94%   +0.24%     
  Files         292      292              
  Lines       39782    40872    +1090     
+ Hits        35685    36763    +1078     
- Misses       4097     4109      +12     
Impacted Files Coverage Δ
datalad/customremotes/tests/ 89.93% <100.00%> (+0.32%) ⬆️
datalad/support/tests/ 57.89% <0.00%> (-3.22%) ⬇️
datalad/distributed/tests/ 44.73% <0.00%> (-1.21%) ⬇️
datalad/support/ 49.12% <0.00%> (-0.88%) ⬇️
datalad/tests/ 86.88% <0.00%> (-0.23%) ⬇️
datalad/support/ 100.00% <0.00%> (ø)
datalad/tests/ 100.00% <0.00%> (ø)
datalad/tests/ 100.00% <0.00%> (ø)
datalad/tests/ 100.00% <0.00%> (ø)
datalad/ui/tests/ 100.00% <0.00%> (ø)
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f915492...392ff7e. Read the comment docs.

mih approved these changes Nov 3, 2020
Copy link

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thx!

@yarikoptic yarikoptic merged commit bb24a2a into datalad:maint Nov 3, 2020
4 checks passed
@yarikoptic yarikoptic added this to the 0.13.6 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
platform-windows Issue concerned with Windows
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants