BF: workarounds to tests on Windows #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted We are looking into the future and upon the flagman Windows 10. Test was failing for me due to assumptions of the past (or whatever). Anyways -- we should have first tested TMPDIR file system capabilities and conditioned based on that instead of which OS we are running
Codecov Report
@@ Coverage Diff @@
## maint #5119 +/- ##
==========================================
+ Coverage 89.70% 89.94% +0.24%
==========================================
Files 292 292
Lines 39782 40872 +1090
==========================================
+ Hits 35685 36763 +1078
- Misses 4097 4109 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No real fixes since should be done either on git-annex level (misbehaving locking when path is too long) or us RFing tests to rely on capabilities of the TMPDIR instead of
if on_windows, so might even start failing where was working before.BUT with today's git-annex (soon to be built on CRON job, will upload to packages/ tomorrow)
datalad/customremotes/tests/test_archives.pytests all pass for me on windows VM.also I gift you the mighty
which.pywhich you might love in a moment of despair.