Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF+TST: Robustify default_result_renderer() #5121

Merged
merged 1 commit into from Nov 4, 2020
Merged

Conversation

mih
Copy link
Member

@mih mih commented Nov 3, 2020

Changes:

  • avoid spurious whitespace when results carry no path
  • prevent crash when path relpath'ing is not possible (fixes Robustify default result renderer #5116)
  • make missing action and status declarations more obvious in the
    output (before it was just None)
  • add test to verify a bunch of corner cases

Once released with 0.13.6, this could bring piece to the win2019 tests of datalad-osf @adswa

Changes:

- avoid spurious whitespace when results carry no path
- prevent crash when path relpath'ing is not possible (fixes dataladgh-5116)
- make missing `action` and `status` declarations more obvious in the
  output (before it was just None)
- add test to verify a bunch of corner cases
@mih mih linked an issue Nov 3, 2020 that may be closed by this pull request
@yarikoptic
Copy link
Member

hm, the travis run somehow abruptly ended for _DL_TMPDIR="/var/tmp/sym link" NOSE_SELECTION_OP="" DATALAD_TESTS_OBSCURE_PREFIX=- DATALAD_LOG_TRACEBACK=collide and I do not see even a button to restart it :-/

appveyor is also failing with smth which seems to be unrelated

======================================================================
FAIL: datalad.distribution.tests.test_get.test_get_flexible_source_candidates_for_submodule
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Miniconda35\envs\test-environment\lib\site-packages\nose\case.py", line 198, in runTest
    self.test(*self.arg)
  File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\utils.py", line 750, in _wrap_with_tempfile
    return t(*(arg + (filename,)), **kw)
  File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\utils.py", line 750, in _wrap_with_tempfile
    return t(*(arg + (filename,)), **kw)
  File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\utils.py", line 750, in _wrap_with_tempfile
    return t(*(arg + (filename,)), **kw)
  File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\distribution\tests\test_get.py", line 149, in test_get_flexible_source_candidates_for_submodule
    from_config=True),
AssertionError: [{'cost': 400, 'url': 'youredead', 'from_config': True, 'name': 'bang'}, {'cost': 500, 'url': 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\datalad_temp_5g1v801p\\sub', 'name': 'origin'}, {'cost': 700, 'url': 'pre-60640353-e1d8-4214-9e16-09686627e747-post', 'from_config': True, 'name': 'bang'}] != [{'cost': 500, 'url': 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\datalad_temp_5g1v801p\\sub', 'name': 'origin'}, {'cost': 700, 'url': 'pre-60640353-e1d8-4214-9e16-09686627e747-post', 'from_config': True, 'name': 'bang'}]

overall I do not mind to see this merged, but travis stall is something new to me, so need to be shown that not related

note: we also have @never_fail helper to really make sure a function doesn't raise, but probably would be overkill here

@mih
Copy link
Member Author

mih commented Nov 4, 2020

overall I do not mind to see this merged, but travis stall is something new to me, so need to be shown that not related

I don't know how to prove that it is not related. But the diff changes the content of a string that is generated. And when rerunning travis, it passed.

@yarikoptic
Copy link
Member

reran and passing travis contributes to the proof ;-)

@yarikoptic yarikoptic merged commit ec25697 into datalad:maint Nov 4, 2020
1 of 2 checks passed
@yarikoptic yarikoptic added this to the 0.13.6 milestone Dec 12, 2020
@mih mih deleted the bf-5116 branch January 15, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robustify default result renderer
2 participants