Avoid repo type assumptions to enable proper tracking branch detection (master) #5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will fail on a crippled file system.
mih
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5128 +/- ##
==========================================
- Coverage 89.58% 89.56% -0.03%
==========================================
Files 299 299
Lines 42075 42085 +10
==========================================
Hits 37692 37692
- Misses 4383 4393 +10
Continue to review full report at Codecov.
|
…ction Force-treating a to-be-added submodule as a GitRepo prevented the detection of a corresponding branch to the active branch, in order to determine the true tracking branch. Which is necessary to discover the effective clone URL from a repository (when it is in adjusted mode). Fixes dataladgh-5107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is the same as #5127 but we the fix ported to master.
Fixes gh-5107