Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Use WitlessRunner in patool wrapper #5141

Merged
merged 1 commit into from Nov 12, 2020
Merged

Conversation

mih
Copy link
Member

@mih mih commented Nov 11, 2020

Ping gh-5003

@mih mih added this to the 0.14.0 milestone Nov 11, 2020
@mih mih mentioned this pull request Nov 11, 2020
11 tasks
@mih mih modified the milestone: 0.14.0 Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #5141 (4da40d9) into master (8081fcf) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5141      +/-   ##
==========================================
- Coverage   89.58%   89.58%   -0.01%     
==========================================
  Files         299      299              
  Lines       42091    42163      +72     
==========================================
+ Hits        37709    37772      +63     
- Misses       4382     4391       +9     
Impacted Files Coverage Δ
datalad/support/archive_utils_patool.py 29.87% <40.00%> (ø)
datalad/plugin/wtf.py 82.40% <0.00%> (-1.20%) ⬇️
datalad/support/parallel.py 94.94% <0.00%> (-0.78%) ⬇️
datalad/plugin/addurls.py 99.00% <0.00%> (-0.75%) ⬇️
datalad/distributed/ora_remote.py 31.19% <0.00%> (-0.06%) ⬇️
datalad/support/annexrepo.py 89.13% <0.00%> (ø)
datalad/plugin/tests/test_addurls.py 100.00% <0.00%> (ø)
datalad/core/distributed/tests/test_clone.py 93.99% <0.00%> (+<0.01%) ⬆️
datalad/core/local/run.py 99.27% <0.00%> (+0.16%) ⬆️
datalad/support/tests/test_locking.py 95.65% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8081fcf...4da40d9. Read the comment docs.

Copy link
Contributor

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't run locally, but the conversion looks good to me. Thanks.

@mih
Copy link
Member Author

mih commented Nov 12, 2020

Thx @kyleam !

@mih mih merged commit 0dbab71 into datalad:master Nov 12, 2020
@mih mih deleted the rf-archiverunner branch November 12, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants