Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: make datalad push not fail to push data on first try to Gin #5148

merged 2 commits into from Nov 12, 2020


Copy link

@mih mih commented Nov 11, 2020

Key commit is 7e27a1d

Exploration is in #5143 and this PR fixes #5143

It would create config variables for `annex-uuid`, and without a
reload we would miss them.
Whenever it finds a remote that is not set to `annex-ignore`, but has no
`annex-uuid` either, it attempts a `localsync`, which will trigger an

Fixes dataladgh-5143
Copy link

adswa commented Nov 11, 2020

Happy to report that this fixes the issues!

(handbook) adina@muninn in /tmp
❱ datalad create woopwopp
[INFO   ] Creating a new annex repo at /tmp/woopwopp 
[INFO   ] Scanning for unlocked files (this may take some time) 
create(ok): /tmp/woopwopp (dataset)
(handbook) adina@muninn in /tmp
❱ cd woopwopp 
(handbook) adina@muninn in /tmp/woopwopp on git:master
❱ echo 1234trgfQTZHBGVF >
(handbook) adina@muninn in /tmp/woopwopp on git:master
❱ datalad save -m "annex something"
add(ok): (file)
save(ok): . (dataset)
action summary:
  add (ok: 1)
  save (ok: 1)

(handbook) adina@muninn in /tmp/woopwopp on git:master
❱ datalad siblings add -s gin --url
[INFO   ] Could not enable annex remote gin. This is expected if gin is a pure Git remote, or happens if it is not accessible. 
[WARNING] Could not detect whether gin carries an annex. If gin is a pure Git remote, this is expected.  
.: gin(-) [ (git)]
(handbook) adina@muninn in /tmp/woopwopp on git:master
❱ datalad push --to gin
copy(ok): (file) [to gin...]                                          
publish(ok): . (dataset) [refs/heads/git-annex->gin:refs/heads/git-annex 4dad75d..4640c23]                                                                      
publish(ok): . (dataset) [refs/heads/master->gin:refs/heads/master [new branch]]
(handbook) adina@muninn in /tmp/woopwopp on git:master

Copy link

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks sensible to me.

Copy link
Member Author

mih commented Nov 12, 2020

Travis didnt even start after 14h 🙄

Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #5148 (7e27a1d) into maint (4434043) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5148      +/-   ##
- Coverage   89.95%   89.93%   -0.03%     
  Files         293      293              
  Lines       40911    40918       +7     
- Hits        36801    36799       -2     
- Misses       4110     4119       +9     
Impacted Files Coverage Δ
datalad/core/distributed/ 88.40% <20.00%> (-0.72%) ⬇️
datalad/support/ 86.87% <100.00%> (+0.01%) ⬆️
datalad/downloaders/tests/ 88.65% <0.00%> (-1.90%) ⬇️
datalad/distribution/tests/ 92.61% <0.00%> (+0.20%) ⬆️
datalad/distribution/ 77.15% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4434043...7e27a1d. Read the comment docs.

Copy link
Member Author

mih commented Nov 12, 2020

Yeah, all green! Thx all.

@mih mih merged commit a621510 into datalad:maint Nov 12, 2020
2 of 4 checks passed
@mih mih deleted the bf-5143 branch November 12, 2020 07:54
@yarikoptic yarikoptic added this to the 0.13.6 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

datalad push fails to push data on first try to Gin
4 participants