Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: datalad.locations.extra-procedures to provide extra location(s) for procedures #5156

Merged
merged 2 commits into from Nov 26, 2020

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Nov 13, 2020

This could be useful to point to extra locations for procedures which might
reside in some subdataset, or an alternative to system/user-wide locations.
E.g. it provides a solution IMHO to #4802 (alternative to #4803) which avoids need for some new semantic of --dataset in "create" command, thus keeping it possible to do

datalad -c datalad.locations.extra-procedures=$PWD/procedures create -d . -c mine sub/

as well as

datalad -c datalad.locations.extra-procedures=$PWD/procedures create -d ^ -c mine sub/

if current dataset is a subdataset within hierarchy. Or point that location to any other arbitrary location (within subdataset, directory, anywhere).
Some inconvenience for use through Python API, for which I filed
#5155

TODOs

  • follow up commit since I believe a docstring needs further unrelated tune up

…for procedures

This could be useful to point to extra locations for procedures which might
reside in some subdataset, or an alternative to system/user-wide locations.
E.g. it could provide a solution for
datalad#4802 which avoids need for some
new semantic of --dataset in "create" command, thus keeping it possible to
do

  datalad -c datalad.locations.extra-procedures=$PWD/procedures create  -d . -c mine sub/

as well as

  datalad -c datalad.locations.extra-procedures=$PWD/procedures create  -d ^ -c mine sub/

if current dataset is a subdataset within hierarchy.  Some inconvenience
for use through Python API, for which I filed
datalad#5155
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5156 (fd91b2f) into master (e4756f6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5156      +/-   ##
==========================================
+ Coverage   89.53%   89.56%   +0.02%     
==========================================
  Files         299      299              
  Lines       42107    42124      +17     
==========================================
+ Hits        37702    37729      +27     
+ Misses       4405     4395      -10     
Impacted Files Coverage Δ
datalad/interface/common_cfg.py 100.00% <ø> (ø)
datalad/interface/run_procedure.py 92.63% <ø> (+1.22%) ⬆️
datalad/interface/tests/test_run_procedure.py 100.00% <100.00%> (ø)
datalad/downloaders/tests/test_http.py 90.54% <0.00%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4756f6...fd91b2f. Read the comment docs.

@yarikoptic yarikoptic added enhancement merge-if-ok OP considers this work done, and requests review/merge labels Nov 14, 2020
@mih
Copy link
Member

mih commented Nov 17, 2020

I have not had the time to investigate this re my original use case. It might still take a considerable time for me to come back to this.

@yarikoptic
Copy link
Member Author

Not sure if anyone else is interested in this one, but since IMHO it does at large addresses #4802, I will merge it in a day or two unless some objections are voiced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement merge-if-ok OP considers this work done, and requests review/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants