New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF/Win: Towards a working creating sibling command #5214
Conversation
Looks lgtm to me. I already forgot - nobody should care about windows in maint? If we still do, rebase is desired |
ah, damn, I keep forgetting to think about which base to use :-) I will rebase |
mkdir is a built-in windows command that does not take flags. Invoking it with -p will create a directory '-p' instead of recursively creating directories. By default, Window's mkdir command will create intermediate directories. Note, though, that this default is due to command extensions being enabled by default under Windows: https://docs.microsoft.com/en-gb/windows-server/administration/windows-commands/mkdir
Codecov Report
@@ Coverage Diff @@
## maint #5214 +/- ##
==========================================
- Coverage 90.44% 90.42% -0.02%
==========================================
Files 294 294
Lines 40924 40926 +2
==========================================
- Hits 37015 37009 -6
- Misses 3909 3917 +8
Continue to review full report at Codecov.
|
@adswa I believe the Travis builds failures are because you rebased/pushed then changed the base on the web interface, rather than the other way around. A force-push of a noop change should sort it out. |
I swear at one point I manage to do it in the correct order. Thx! Pushed an empty commit. |
There are a range of issues with create sibling (see #5211) and I'm not sure if it is possible possible to make it work, but I at least wanted to start.
mkdir
without -p on Windows|| :
as a command