Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF/Win: Towards a working creating sibling command #5214

Merged
merged 3 commits into from Dec 11, 2020
Merged

Conversation

adswa
Copy link
Member

@adswa adswa commented Dec 7, 2020

There are a range of issues with create sibling (see #5211) and I'm not sure if it is possible possible to make it work, but I at least wanted to start.

  • use mkdir without -p on Windows
  • prevent failure due to not recognizing || : as a command

@yarikoptic
Copy link
Member

Looks lgtm to me. I already forgot - nobody should care about windows in maint? If we still do, rebase is desired

@adswa
Copy link
Member Author

adswa commented Dec 10, 2020

nobody should care about windows in maint? If we still do, rebase is desired

ah, damn, I keep forgetting to think about which base to use :-) I will rebase

mkdir is a built-in windows command that does not take flags.
Invoking it with -p will create a directory '-p' instead of
recursively creating directories.
By default, Window's mkdir command will create intermediate
directories.
Note, though, that this default is due to command extensions being
enabled by default under Windows:
https://docs.microsoft.com/en-gb/windows-server/administration/windows-commands/mkdir
@adswa adswa changed the base branch from master to maint December 10, 2020 14:54
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #5214 (72024d9) into maint (43b5e4a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5214      +/-   ##
==========================================
- Coverage   90.44%   90.42%   -0.02%     
==========================================
  Files         294      294              
  Lines       40924    40926       +2     
==========================================
- Hits        37015    37009       -6     
- Misses       3909     3917       +8     
Impacted Files Coverage Δ
datalad/distribution/create_sibling.py 85.67% <100.00%> (+0.08%) ⬆️
datalad/downloaders/tests/test_http.py 88.59% <0.00%> (-1.91%) ⬇️
datalad/support/sshconnector.py 87.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b5e4a...72024d9. Read the comment docs.

@kyleam
Copy link
Collaborator

kyleam commented Dec 10, 2020

@adswa I believe the Travis builds failures are because you rebased/pushed then changed the base on the web interface, rather than the other way around. A force-push of a noop change should sort it out.

@adswa
Copy link
Member Author

adswa commented Dec 11, 2020

@adswa I believe the Travis builds failures are because you rebased/pushed then changed the base on the web interface, rather than the other way around. A force-push of a noop change should sort it out.

I swear at one point I manage to do it in the correct order. Thx! Pushed an empty commit.

kyleam
kyleam approved these changes Dec 11, 2020
@kyleam kyleam merged commit a1ab6b7 into datalad:maint Dec 11, 2020
1 check passed
@yarikoptic yarikoptic added this to the 0.13.6 milestone Dec 12, 2020
@adswa adswa deleted the bf-5211 branch December 18, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants