Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH(UX): do not repeat entry for token and aws key/secret #5219

Merged
merged 1 commit into from Dec 9, 2020

Conversation

yarikoptic
Copy link
Member

I failed to find an issue but I know that it annoyed many people, me included,
whenever long secrets such as tokens and keys for AWS were asked to be repeated.
There is IMHO no reason for that since they are never typed in and validation
of correct entry is beyond human capabilities without much straining

A followup to #5218

I failed to find an issue but I know that it annoyed many people, me included,
whenever long secrets such as tokens and keys for AWS were asked to be repeated.
There is IMHO no reason for that since they are never typed in and validation
of correct entry is beyond human capabilities without much straining
kyleam
kyleam approved these changes Dec 9, 2020
Copy link
Collaborator

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #5219 (4aa19c4) into maint (1b013a8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5219      +/-   ##
==========================================
- Coverage   89.91%   89.89%   -0.02%     
==========================================
  Files         294      294              
  Lines       40960    40963       +3     
==========================================
- Hits        36829    36824       -5     
- Misses       4131     4139       +8     
Impacted Files Coverage Δ
datalad/downloaders/credentials.py 82.35% <100.00%> (+0.31%) ⬆️
datalad/downloaders/tests/test_http.py 88.59% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b013a8...4aa19c4. Read the comment docs.

@kyleam kyleam merged commit d52fc46 into datalad:maint Dec 9, 2020
1 check passed
@yarikoptic yarikoptic deleted the enh-ux-tokens branch December 9, 2020 23:48
@yarikoptic yarikoptic added this to the 0.13.6 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants