RF: Use datalad.locations.sockets as dedicated configuration #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of putting sockets into the cache dir. This makes it possible to place sockets specifically, rather than all cache content. This will make it easier to workaround filesystem limitations (dataladgh-4075), and path length issues (dataladgh-5232). Keep default location unchanged `<cachedir>/sockets`
Codecov Report
@@ Coverage Diff @@
## maint #5238 +/- ##
==========================================
- Coverage 90.44% 90.42% -0.02%
==========================================
Files 294 294
Lines 40924 40924
==========================================
- Hits 37015 37007 -8
- Misses 3909 3917 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Instead of putting sockets into the cache dir. This makes it possible to
place sockets specifically, rather than all cache content. This will
make it easier to workaround filesystem limitations (gh-4075), and
path length issues (gh-5232).
Keep default location unchanged
<cachedir>/socketsHowever, using this location seems suboptimal. $HOME (which contains
cachedirtypically), may be mounted from another machine./tmpis much more commonly used for this on Linux (X Server, KDE, ...), and more likely to be a local drive.Using this new config makes things work on OSX re pathlength https://ci.appveyor.com/project/mih/appveyor-datalad/builds/36771014/job/r7yif4oct81baee7