Restore progress logging behavior when non-interactive #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When JSON progress by git-annex was handled with `ProcessAnnexProgressIndicators` there was no progress logging in non-interactive mode, unless log level was set to 1. With the switch to `AnnexJsonProtocol` this behavior changed and now non-interactive logging comes out at the default INFO level. This change standardizes the non-interactive log level to 5, as used in other places too.
Codecov Report
@@ Coverage Diff @@
## master #5259 +/- ##
==========================================
+ Coverage 90.20% 90.24% +0.04%
==========================================
Files 297 297
Lines 41666 41496 -170
==========================================
- Hits 37583 37449 -134
+ Misses 4083 4047 -36
Continue to review full report at Codecov.
|
kyleam
approved these changes
Dec 17, 2020
|
Thx! |
|
EDIT: Sorry, not, I was wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JSON progress by git-annex was handled with
ProcessAnnexProgressIndicatorsthere was no progress logging in non-interactive mode, unless log level was set to 1.With the switch to
AnnexJsonProtocolthis behavior changed and now non-interactive logging comes out at the default INFO level.This change standardizes the non-interactive log level to 5, as used in other places too.
The second commit removes the already obsolete
ProcessAnnexProgressIndicatorsand its tests.