Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: create_sibling cp -- use -R for --recursive and -p for --preserve #5269

Merged
merged 2 commits into from Jan 4, 2021

Conversation

yarikoptic
Copy link
Member

So works also on OSX

could be seen among fails against released version on https://github.com/datalad/git-annex/runs/1638321268?check_suite_focus=true#step:12:2515

@yarikoptic yarikoptic added this to the 0.13.7 milestone Jan 3, 2021
@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #5269 (0a0bd72) into maint (db77587) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5269      +/-   ##
==========================================
+ Coverage   90.44%   90.46%   +0.01%     
==========================================
  Files         294      294              
  Lines       40991    40991              
==========================================
+ Hits        37076    37084       +8     
+ Misses       3915     3907       -8     
Impacted Files Coverage Δ
datalad/distribution/create_sibling.py 85.67% <66.66%> (ø)
datalad/downloaders/tests/test_http.py 90.49% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db77587...0a0bd72. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyleam kyleam merged commit 6d74b7f into datalad:maint Jan 4, 2021
@kyleam
Copy link
Contributor

kyleam commented Jan 4, 2021

Note to aid any future digging: gh-5108 made these same changes on master.

@yarikoptic
Copy link
Member Author

damn... indeed, should have just adopted that PR changes for maint :-/

@yarikoptic yarikoptic deleted the bf-cp branch April 29, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants