NF: addurls: Support passing list of records #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The urlfile argument takes records via a file, but when addurls is called from the python interface, specifying an iterable of records can be more convenient. Add support for that. Using urlfile as the name for the positional argument doesn't fit for this particular use case, but leave it as is to avoiding breaking existing python callers that use it as a keyword argument. Closes datalad#4906.
kyleam
force-pushed
the
addurls-no-file
branch
from
4556b6f
to
c85c368
Compare
Codecov Report
@@ Coverage Diff @@
## master #5285 +/- ##
==========================================
+ Coverage 90.26% 90.31% +0.04%
==========================================
Files 297 298 +1
Lines 41632 41737 +105
==========================================
+ Hits 37580 37695 +115
+ Misses 4052 4042 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The urlfile argument takes records via a file, but when addurls is
called from the python interface, specifying an iterable of records
can be more convenient. Add support for that.
Using urlfile as the name for the positional argument doesn't fit for
this particular use case, but leave it as is to avoiding breaking
existing python callers that use it as a keyword argument.
Closes #4906.
https://ci.appveyor.com/project/mih/datalad/builds/37138665/job/49lq604vukvu6x69