Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old ORA configs #5425

Merged
merged 1 commit into from Feb 22, 2021
Merged

Conversation

bpoldrack
Copy link
Member

Configuring ssh-host and base-path for an ORA remote predates ria+ URLs
and the consideration of git's URL rewrites. Those configs are also not
capable of specifying an HTTP connection let alone a separation of url
and push-url. Respect them for now if we don't find a URL, but issue a
deprecation warning. Will be removed entirely eventually.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #5425 (b5f7f9f) into master (61790a7) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5425   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files         296      296           
  Lines       41800    41794    -6     
=======================================
- Hits        37409    37404    -5     
+ Misses       4391     4390    -1     
Impacted Files Coverage Δ
datalad/distributed/ora_remote.py 30.47% <0.00%> (+0.30%) ⬆️
datalad/downloaders/tests/test_http.py 90.49% <0.00%> (-0.96%) ⬇️
datalad/downloaders/base.py 77.38% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61790a7...b5f7f9f. Read the comment docs.

Copy link
Contributor

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a missing space in the warning, looks good as far as I can tell.

datalad/distributed/ora_remote.py Show resolved Hide resolved
datalad/distributed/ora_remote.py Show resolved Hide resolved
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx! Comments by @kyleam make sense.

Configuring ssh-host and base-path for an ORA remote predates ria+ URLs
and the consideration of git's URL rewrites. Those configs are also not
capable of specifying an HTTP connection let alone a separation of `url`
and `push-url`. Respect them for now if we don't find a URL, but issue a
deprecation warning. Will be removed entirely eventually.
@bpoldrack
Copy link
Member Author

Thx! Addressed the comments, only NFS stall left - hhus merging.

@bpoldrack bpoldrack merged commit bc8e364 into datalad:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants