Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: optional push-url for create-sibling-ria #5428

Merged
merged 2 commits into from Mar 3, 2021

Conversation

bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Feb 19, 2021

Expose ORA's new push-url in create-sibling-ria. This is used to configure the ORA special remote as well as to create the sibling in store.

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #5428 (3677f00) into master (365ef82) will increase coverage by 0.03%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5428      +/-   ##
==========================================
+ Coverage   89.48%   89.51%   +0.03%     
==========================================
  Files         296      296              
  Lines       41800    41903     +103     
==========================================
+ Hits        37404    37511     +107     
+ Misses       4396     4392       -4     
Impacted Files Coverage Δ
datalad/distributed/ora_remote.py 30.47% <0.00%> (+0.30%) ⬆️
datalad/distributed/create_sibling_ria.py 81.06% <100.00%> (+0.34%) ⬆️
...talad/distributed/tests/test_create_sibling_ria.py 100.00% <100.00%> (ø)
datalad/downloaders/tests/test_http.py 88.59% <0.00%> (-1.91%) ⬇️
datalad/interface/tests/test_run_procedure.py 100.00% <0.00%> (ø)
datalad/core/local/run.py 99.11% <0.00%> (+<0.01%) ⬆️
datalad/interface/tests/test_rerun.py 98.49% <0.00%> (+0.03%) ⬆️
datalad/interface/rerun.py 96.14% <0.00%> (+0.05%) ⬆️
datalad/core/local/tests/test_run.py 99.27% <0.00%> (+0.09%) ⬆️
datalad/support/annexrepo.py 90.69% <0.00%> (+0.09%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 365ef82...3677f00. Read the comment docs.

@kyleam
Copy link
Contributor

kyleam commented Feb 19, 2021

Should create-sibling-ria use the push-url for the git remote, too (same way: url + push-url, of course)?

Seems like a good idea to me as long as there isn't an obvious scenario where that wouldn't be desirable. I can't think of one, but then again I've mostly been using git's remote.<name>.pushurl to frame/think about this new ria option, so perhaps I'm missing a use case where they don't overlap.

This is used to configure the ORA remote as well as the git remote to
use this push-url. In addition the creation of the sibling in store is
done via the access method defined by the push-url.
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and works as advertised for me. Thx!

@mih mih merged commit ce0f6b5 into datalad:master Mar 3, 2021
@mih mih deleted the enh-create-sibling-ria branch March 3, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants