Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM: deprecated no_annex Python API option #5441

Merged
merged 1 commit into from Aug 15, 2021
Merged

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Feb 25, 2021

leftover from #5426

needs datalad-metalad release IIRC

@yarikoptic yarikoptic added the severity-minor a problem which doesn't affect the package's usefulness, and is presumably trivial to fix label Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #5441 (1668b40) into master (76d9c36) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5441   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         296      296           
  Lines       41873    41870    -3     
=======================================
- Hits        37477    37475    -2     
+ Misses       4396     4395    -1     
Impacted Files Coverage Δ
datalad/core/local/create.py 94.32% <ø> (+1.27%) ⬆️
datalad/interface/base.py 91.09% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d9c36...1668b40. Read the comment docs.

@yarikoptic yarikoptic added the blocked Something external is blocking this for the time being label Mar 29, 2021
@yarikoptic yarikoptic added this to the 0.15.0 milestone Aug 5, 2021
@mih
Copy link
Member

mih commented Aug 15, 2021

I think it is OK to merge this, and have metalad be fixed separately.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for thinking off it.

@mih mih merged commit 379d4e2 into datalad:master Aug 15, 2021
@mih
Copy link
Member

mih commented Aug 16, 2021

LOL, the last test run was too old. master itself was incompatible with this change. No idea how that could happen. Will fix.

mih added a commit to mih/datalad that referenced this pull request Aug 16, 2021
mih added a commit that referenced this pull request Aug 16, 2021
Fixup after #5441 which only removed half of `no_annex`
@yarikoptic yarikoptic deleted the enh-noannex branch October 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something external is blocking this for the time being severity-minor a problem which doesn't affect the package's usefulness, and is presumably trivial to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants