Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Unlock used to pass resolved paths to status #5458

merged 2 commits into from Mar 3, 2021


Copy link

This destroys the logic within status that is based on "raw" input. In the particular case triggering this PR, status wouldn't realize the original call was passing . as the path argument.

Closes #5456

Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #5458 (83e79f6) into maint (03d0fd3) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5458      +/-   ##
- Coverage   89.55%   89.52%   -0.03%     
  Files         296      296              
  Lines       41763    41954     +191     
+ Hits        37401    37560     +159     
- Misses       4362     4394      +32     
Impacted Files Coverage Δ
datalad/interface/tests/ 98.05% <100.00%> (+0.12%) ⬆️
datalad/interface/ 100.00% <100.00%> (ø)
datalad/downloaders/tests/ 88.59% <0.00%> (-1.91%) ⬇️
datalad/distributed/ 30.47% <0.00%> (-1.18%) ⬇️
datalad/downloaders/ 93.83% <0.00%> (-0.39%) ⬇️
datalad/downloaders/ 77.19% <0.00%> (-0.20%) ⬇️
...talad/distributed/tests/ 100.00% <0.00%> (ø)
datalad/core/local/ 99.11% <0.00%> (+<0.01%) ⬆️
datalad/interface/tests/ 98.49% <0.00%> (+0.03%) ⬆️
datalad/interface/ 96.14% <0.00%> (+0.05%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d0fd3...83e79f6. Read the comment docs.

@bpoldrack bpoldrack changed the base branch from master to maint March 3, 2021 14:57
Copy link

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

The branch is based off of maint, but it looks like you forgot to change the base for the PR. Assuming nobody else chimes in requesting changes, I'd be fine with skipping the "change base on PR, trigger rebuild" step, instead just merging this to maint locally and waiting for the PR to be closed when maint hits master.

Edit: I see you changed the base as I was typing that. So amend the above to 'skipping the "trigger rebuild" step' :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants