Fix publish-depends for ORA remotes in clone (in maint this time) #5488

mih · 2021-03-12T06:09:01Z

This is #5415 but against maint

Setting the publication dependency for 'origin' on an ORA remote in postclone routine didn't properly account for multiple accessible ORA remotes or the fact that none of them may be associated with the RIA store we are cloning from. Now, first check for an ORA remote with the same store URL registered and if there is none check whether the store has a remote's uuid stored in the .git/config of the dataset. If we have that remote enabled, set the dependency on it. (Closes datalad#5396)

codecov · 2021-03-12T06:24:44Z

Codecov Report

Merging #5488 (a8ba155) into maint (15de1fb) will decrease coverage by 0.60%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##            maint    #5488      +/-   ##
==========================================
- Coverage   90.15%   89.55%   -0.61%     
==========================================
  Files         296      296              
  Lines       41796    41824      +28     
==========================================
- Hits        37683    37454     -229     
- Misses       4113     4370     +257

Impacted Files	Coverage Δ
datalad/core/distributed/clone.py	`90.93% <92.00%> (+0.02%)`	⬆️
datalad/core/distributed/tests/test_clone.py	`96.95% <100.00%> (-0.35%)`	⬇️
datalad/support/due.py	`48.00% <0.00%> (-32.00%)`	⬇️
datalad/ui/utils.py	`56.25% <0.00%> (-21.88%)`	⬇️
datalad/metadata/extractors/tests/test_base.py	`87.80% <0.00%> (-12.20%)`	⬇️
datalad/metadata/extractors/tests/test_xmp.py	`88.46% <0.00%> (-11.54%)`	⬇️
datalad/metadata/extractors/tests/test_image.py	`88.46% <0.00%> (-11.54%)`	⬇️
datalad/support/archive_utils_patool.py	`29.87% <0.00%> (-10.39%)`	⬇️
datalad/metadata/tests/test_extract_metadata.py	`91.11% <0.00%> (-8.89%)`	⬇️
datalad/metadata/extractors/tests/test_exif.py	`92.00% <0.00%> (-8.00%)`	⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15de1fb...a8ba155. Read the comment docs.

mih changed the base branch from master to maint March 12, 2021 06:09

bpoldrack merged commit 8d24773 into datalad:maint Mar 12, 2021
14 of 15 checks passed

mih deleted the bf-5396 branch March 19, 2021 11:44

Fix publish-depends for ORA remotes in clone (in maint this time) #5488

Fix publish-depends for ORA remotes in clone (in maint this time) #5488

mih commented Mar 12, 2021

codecov bot commented Mar 12, 2021 •

edited

Fix publish-depends for ORA remotes in clone (in maint this time) #5488

Fix publish-depends for ORA remotes in clone (in maint this time) #5488

Conversation

mih commented Mar 12, 2021

codecov bot commented Mar 12, 2021 • edited

Codecov Report

codecov bot commented Mar 12, 2021 •

edited