-
Notifications
You must be signed in to change notification settings - Fork 110
ENH: Make --version output just version, and CMD --version output module and its version #5543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ule and its version I might have went a little too wild, but I felt that having clean output of datalad --version is nice -- it could facilitate use by scripts since would no longer need parsing etc (but also might break them now). So here is how it would look now with these changes: $> datalad --version 0.14.1.dev129 $> datalad install --version datalad 0.14.1.dev129 $> datalad containers-list --version datalad_container 1.1.2 $> git-annex-remote-datalad --version datalad 0.14.1.dev129 Closes datalad#5527
Codecov Report
@@ Coverage Diff @@
## master #5543 +/- ##
==========================================
+ Coverage 88.52% 88.56% +0.04%
==========================================
Files 296 296
Lines 42467 42510 +43
==========================================
+ Hits 37592 37651 +59
+ Misses 4875 4859 -16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and it's nice that it fixed the deeper issue in gh-3067.
---------- | ||
parser: | ||
mod_name: str, optional | ||
include_name: bool, optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly about it, but my vote would be to just stick with the previous output and always include the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also luke warm about this change -- benefit is minimal and it might break someone's (unlikely but possible to exist) script. May be @mih has an opinion on this minute aspect?
Co-authored-by: Kyle Meyer <kyle@kyleam.com>
ok, added a commit to revert back to the prior behavior for |
I might have went a little too wild, but I felt that having clean output
of datalad --version is nice -- it could facilitate use by scripts since
would no longer need parsing etc (but also might break them now).
So here is how it would look now with these changes:
Closes #5527
edit: a side effect, it also addresses #3067 which was worked around via adding
--
to separate out command fordatalad run
. Now would even work in thedatalad run whatever --version
without--