Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: create-sibling: Make default sibling choice more accessible #5550

Merged
merged 1 commit into from Apr 9, 2021

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Apr 7, 2021

When --name isn't specified, create-sibling will use the hostname for
an SSH URL and "local" for a local path. At the default logging
level, however, the caller isn't told what the selected name is. And,
for scripting purposes, the name can't be easily determined because
it's not available in the result record.

Promote the debug-level message about the default sibling name to an
info-level message, and add a "sibling_name" field to the result
record.

Closes #1986.

When --name isn't specified, create-sibling will use the hostname for
an SSH URL and "local" for a local path.  At the default logging
level, however, the caller isn't told what the selected name is.  And,
for scripting purposes, the name can't be easily determined because
it's not available in the result record.

Promote the debug-level message about the default sibling name to an
info-level message, and add a "sibling_name" field to the result
record.

Closes datalad#1986.
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #5550 (bc1a72b) into master (f2f95b3) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head bc1a72b differs from pull request most recent head 506bea4. Consider uploading reports for the commit 506bea4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5550      +/-   ##
==========================================
- Coverage   88.52%   88.42%   -0.10%     
==========================================
  Files         296      296              
  Lines       42467    42487      +20     
==========================================
- Hits        37592    37568      -24     
- Misses       4875     4919      +44     
Impacted Files Coverage Δ
datalad/distribution/create_sibling.py 85.95% <100.00%> (+0.03%) ⬆️
datalad/distribution/tests/test_create_sibling.py 98.37% <100.00%> (+<0.01%) ⬆️
datalad/support/archive_utils_patool.py 29.87% <0.00%> (-10.39%) ⬇️
datalad/support/tests/test_path.py 92.50% <0.00%> (-5.00%) ⬇️
datalad/tests/test_archives.py 91.83% <0.00%> (-3.41%) ⬇️
datalad/local/copy_file.py 93.61% <0.00%> (-2.56%) ⬇️
datalad/interface/tests/test_unlock.py 97.97% <0.00%> (-2.03%) ⬇️
datalad/support/sshconnector.py 84.22% <0.00%> (-1.80%) ⬇️
datalad/plugin/addurls.py 94.80% <0.00%> (-1.56%) ⬇️
datalad/downloaders/credentials.py 84.11% <0.00%> (-1.18%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f95b3...506bea4. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thx!

@kyleam
Copy link
Contributor Author

kyleam commented Apr 9, 2021

Good idea, thx!

It was suggested by some random @mih guy :)

@kyleam kyleam merged commit 6903d6b into datalad:master Apr 9, 2021
@kyleam kyleam deleted the create-sibling-provide-name branch April 9, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default name non-obvious for create-sibling
2 participants