Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Remove GitRepo.pull() #5558

Merged
merged 1 commit into from
Apr 17, 2021
Merged

RF: Remove GitRepo.pull() #5558

merged 1 commit into from
Apr 17, 2021

Conversation

mih
Copy link
Member

@mih mih commented Apr 12, 2021

This method is used nowhere in the code, and its obsoleteness
was put in an issue more than a year ago.

Closes #4132

This method is used nowhere in the code, and its obsoleteness
was put in an issue more than a year ago.

Fixes dataladgh-4132
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #5558 (27c0355) into master (6d3ac7e) will decrease coverage by 1.60%.
The diff coverage is 100.00%.

❗ Current head 27c0355 differs from pull request most recent head c88edbf. Consider uploading reports for the commit c88edbf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5558      +/-   ##
==========================================
- Coverage   90.17%   88.56%   -1.61%     
==========================================
  Files         299      296       -3     
  Lines       42528    42461      -67     
==========================================
- Hits        38351    37607     -744     
- Misses       4177     4854     +677     
Impacted Files Coverage Δ
datalad/support/gitrepo.py 91.73% <ø> (+0.11%) ⬆️
datalad/support/tests/test_gitrepo.py 99.79% <ø> (-0.11%) ⬇️
datalad/core/distributed/tests/test_clone.py 97.22% <100.00%> (+<0.01%) ⬆️
datalad/distribution/create_sibling.py 85.95% <100.00%> (+0.03%) ⬆️
datalad/distribution/tests/test_create_sibling.py 98.37% <100.00%> (-0.47%) ⬇️
datalad/interface/run_procedure.py 93.29% <100.00%> (+0.04%) ⬆️
datalad/interface/tests/test_run_procedure.py 100.00% <100.00%> (ø)
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_audio.py 19.35% <0.00%> (-80.65%) ⬇️
datalad/metadata/extractors/xmp.py 12.96% <0.00%> (-79.63%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3ac7e...c88edbf. Read the comment docs.

@bpoldrack
Copy link
Member

Fine with me.

@mih mih added this to To be considered in Release 1.0 via automation Apr 12, 2021
@mih
Copy link
Member Author

mih commented Apr 17, 2021

Thx @bpoldrack

@mih mih closed this Apr 17, 2021
Release 1.0 automation moved this from To be considered to Abandoned Apr 17, 2021
@mih mih reopened this Apr 17, 2021
Release 1.0 automation moved this from Abandoned to WiP Apr 17, 2021
@mih mih merged commit fd80ebe into datalad:master Apr 17, 2021
Release 1.0 automation moved this from WiP to DONE Apr 17, 2021
@mih mih deleted the bf-4132 branch April 17, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 1.0
  
DONE
Development

Successfully merging this pull request may close these issues.

Remove GitRepo.pull()
2 participants