Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Don't call get_interface_groups with include_plugins=True #5564

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Apr 12, 2021

Calling get_interface_groups() with include_plugins=True was marked as
deprecated in gh-5554.

Update: And also remove datalad.locations.{system,user}-plugins options.

Calling get_interface_groups() with include_plugins=True was marked as
deprecated in dataladgh-5554.
@kyleam kyleam requested a review from mih April 12, 2021 20:28
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #5564 (a98e1b5) into master (f937558) will decrease coverage by 1.82%.
The diff coverage is 100.00%.

❗ Current head a98e1b5 differs from pull request most recent head b94d0f4. Consider uploading reports for the commit b94d0f4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5564      +/-   ##
==========================================
- Coverage   90.22%   88.39%   -1.83%     
==========================================
  Files         308      305       -3     
  Lines       42516    42480      -36     
==========================================
- Hits        38361    37552     -809     
- Misses       4155     4928     +773     
Impacted Files Coverage Δ
datalad/interface/common_cfg.py 100.00% <ø> (ø)
datalad/api.py 67.39% <100.00%> (ø)
datalad/cmdline/main.py 74.89% <100.00%> (ø)
datalad/distribution/dataset.py 94.40% <100.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f937558...b94d0f4. Read the comment docs.

@mih
Copy link
Member

mih commented Apr 13, 2021

Crippled tests show #5300 and brew is still having issues installing git-annex.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the clean-up!

@mih mih merged commit 2934d29 into datalad:master Apr 13, 2021
@kyleam kyleam deleted the dont-use-include-plugins branch April 13, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants