Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Move ls() and ls_webui to -deprecated #5569

Merged
merged 5 commits into from
Apr 16, 2021
Merged

RF: Move ls() and ls_webui to -deprecated #5569

merged 5 commits into from
Apr 16, 2021

Conversation

mih
Copy link
Member

@mih mih commented Apr 14, 2021

They landed there with datalad/datalad-deprecated#2

Closes #5563
Closes #5359

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #5569 (42edea2) into master (c2633eb) will decrease coverage by 1.83%.
The diff coverage is 83.33%.

❗ Current head 42edea2 differs from pull request most recent head e45f930. Consider uploading reports for the commit e45f930 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5569      +/-   ##
==========================================
- Coverage   90.07%   88.23%   -1.84%     
==========================================
  Files         308      301       -7     
  Lines       42502    41703     -799     
==========================================
- Hits        38283    36796    -1487     
- Misses       4219     4907     +688     
Impacted Files Coverage Δ
datalad/interface/__init__.py 100.00% <ø> (ø)
datalad/tests/test_utils.py 95.71% <ø> (-0.61%) ⬇️
datalad/utils.py 83.54% <ø> (-1.56%) ⬇️
datalad/support/tests/test_annexrepo.py 97.16% <80.00%> (-0.28%) ⬇️
datalad/version.py 40.90% <100.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2633eb...e45f930. Read the comment docs.

@mih mih force-pushed the rf-ls branch 2 times, most recently from f296550 to de6cf13 Compare April 14, 2021 13:11
@mih
Copy link
Member Author

mih commented Apr 14, 2021

So this is a more complex transition. The crawler also needs this.

@mih
Copy link
Member Author

mih commented Apr 15, 2021

I have made a release of -deprecated to pypi, such that the crawler can simply depend on it, to maintain availability of ls(), whether or not the installed datalad provides it.

mih added a commit to datalad/datalad-crawler that referenced this pull request Apr 15, 2021
This extension is co-installable with -core, without breaking it --
regardless of whether or not -core still provides some functionality.

Due to the age of the crawler, it is likely to be affected most by
potential deprecations. Adding this dependency will make it robust
against coming changes, such as the `ls` deprecation
(datalad/datalad#5569).
@mih
Copy link
Member Author

mih commented Apr 15, 2021

I have put up datalad/datalad-crawler#94 for the crawler

mih added 3 commits April 15, 2021 17:14
It uses `ls` for benchmarking. It makes sense to me to keep the
benchmarks as is, and merely provide the missing dependency.
@mih
Copy link
Member Author

mih commented Apr 16, 2021

Minus the macos git-annex installation issue all is good now. The -crawler release 0.8.4 ensures availability of ls regardless of the state of the datalad core installation state. @yarikoptic gave feedback on adding -deprecated as a benchmark CI run dependency in order to maintain the normal set of benchmarks.

Bottom line: done!

@mih mih merged commit 1d347d1 into datalad:master Apr 16, 2021
@mih mih deleted the rf-ls branch April 16, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ls and ls_webui to deprecated Discontinue or RF ls command
1 participant