Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Move AutomagicIO functionality to -deprecated #5577

Merged
merged 1 commit into from Apr 19, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Apr 16, 2021

Analog to the WebUI transition, all functionality stays as-is, given the
extension is installed. If the functionality is requested , but the
extension is not installed, users are prompted to install it.

Tests are now placed in the extension too.

Closes gh-4742

when merged, move:

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #5577 (eb6374e) into master (470d187) will decrease coverage by 1.68%.
The diff coverage is 0.00%.

❗ Current head eb6374e differs from pull request most recent head 795b8c4. Consider uploading reports for the commit 795b8c4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5577      +/-   ##
==========================================
- Coverage   90.11%   88.42%   -1.69%     
==========================================
  Files         304      299       -5     
  Lines       41735    41335     -400     
==========================================
- Hits        37609    36550    -1059     
- Misses       4126     4785     +659     
Impacted Files Coverage Δ
datalad/__main__.py 39.65% <0.00%> (-35.35%) ⬇️
datalad/tests/test__main__.py 100.00% <ø> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_to_figshare.py 0.00% <0.00%> (-100.00%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470d187...795b8c4. Read the comment docs.

Analog to the WebUI transition, all functionality stays as-is, given the
extension is installed. If the functionality is requested , but the
extension is not installed, users are prompted to install it.

Tests are now placed in the extension too.

Closes dataladgh-4742
@mih
Copy link
Member Author

mih commented Apr 16, 2021

#5578 fixes the travis failure that is already in master. The appveyor failure is the mac installation issue. The crippled FS failure is #5300

Copy link
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

datalad/__main__.py Show resolved Hide resolved
@mih
Copy link
Member Author

mih commented Apr 19, 2021

thx @bpoldrack for the review.

@mih mih merged commit 7b407ec into datalad:master Apr 19, 2021
@mih mih deleted the rf-auto branch April 19, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Re)move automagic IO functionality?
2 participants