Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF: annexjson2result() could not handle file=null results #5580

Merged
merged 1 commit into from Apr 17, 2021
Merged

BF: annexjson2result() could not handle file=null results #5580

merged 1 commit into from Apr 17, 2021

Conversation

mih
Copy link
Member

@mih mih commented Apr 16, 2021 •
edited

In this case, there should be no 'path' property at all.

Established a place to have any tests for the result utility code.
Far from being comprehensive...

Closes #5490

@mih mih linked an issue Apr 16, 2021 that may be closed by this pull request
annexjson2result cannot handle file=null results #5490
Closed
@mih mih changed the title BF: annexjson2resulti() could not handle file=null results BF: annexjson2result() could not handle file=null results Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021 •
edited

Codecov Report

Merging #5580 (5ae982e) into maint (b16632f) will decrease coverage by 5.38%.
The diff coverage is 100.00%.

❗ Current head 5ae982e differs from pull request most recent head 6b94f6b. Consider uploading reports for the commit 6b94f6b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5580      +/-   ##
==========================================
- Coverage   90.15%   84.77%   -5.39%     
==========================================
  Files         296      294       -2     
  Lines       42067    42061       -6     
==========================================
- Hits        37927    35657    -2270     
- Misses       4140     6404    +2264
Impacted Files Coverage Δ
datalad/interface/results.py 96.87% <100.00%> (-0.79%) ⬇️
datalad/interface/tests/test_results.py 100.00% <100.00%> (ø)
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_audio.py 19.35% <0.00%> (-80.65%) ⬇️
datalad/metadata/extractors/xmp.py 12.96% <0.00%> (-79.63%) ⬇️
datalad/metadata/extractors/exif.py 18.75% <0.00%> (-78.13%) ⬇️
datalad/metadata/extractors/image.py 19.35% <0.00%> (-77.42%) ⬇️
datalad/metadata/extractors/audio.py 20.00% <0.00%> (-77.15%) ⬇️
datalad/metadata/extractors/tests/test_exif.py 24.00% <0.00%> (-76.00%) ⬇️
datalad/metadata/extractors/tests/test_xmp.py 26.92% <0.00%> (-73.08%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16632f...6b94f6b. Read the comment docs.

@mih
BF: annexjson2resulti() could not handle file=null results
6b94f6b 
In this case, there should be no 'path' property at all.

Established a place to have any tests for the result utility code.
Far from being comprehensive...

Closes dataladgh-5490
@mih
Copy link
Member Author

mih commented Apr 16, 2021

I actually included the new test now ...

@kyleam thx for the feedback on the fix already!

kyleam
kyleam reviewed Apr 16, 2021
View reviewed changes
datalad/interface/tests/test_results.py
)


@ with_tempfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I didn't know that having a space after @ was legal syntax, but that seems to work fine.

@kyleam
Copy link
Contributor

kyleam commented Apr 16, 2021

I actually included the new test now ...

Ah, sorry, I assumed there was a missing word in the initial description (or something) and didn't realize a test was coming.

@mih mih merged commit 1878d0d into datalad:maint Apr 17, 2021
@mih mih deleted the bf-5490 branch April 17, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleam kyleam kyleam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

annexjson2result cannot handle file=null results
2 participants
@mih @kyleam