MNT: github: Add compatibility wrapper for GithubException #5603
Conversation
A few spots in the code base instantiate GithubException with two arguments, but in PyGithub v1.55 (released today) GithubException and its subclasses require an additional argument (`headers`). Add a helper that tries to create an exception with three arguments, falling back to two arguments for compatibility. Note that using None for the headers follows what was done in the upstream commit, ddd437a7c (Export headers in GithubException). Closes datalad#5602.
Codecov Report
@@ Coverage Diff @@
## maint #5603 +/- ##
===========================================
- Coverage 90.24% 50.38% -39.87%
===========================================
Files 299 296 -3
Lines 42224 42194 -30
===========================================
- Hits 38106 21258 -16848
- Misses 4118 20936 +16818
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I would have better checked for external_versions['github'] <= '1.5' but apparently github doesn't provide __version__ and our current logic there which falls fallback to pkg_resources
$> python -c 'from datalad.support.external_versions import external_versions as ev; print(ev["github"])'
UNKNOWN
is not good enough since the distribution package is named pygithub and not github.
So I guess for now let's just stick with duck typing but I will submit a PR to resolve this versioning gotcha
A few spots in the code base instantiate GithubException with two
arguments, but in PyGithub v1.55 (released today) GithubException and
its subclasses require an additional argument (
headers).Add a helper that tries to create an exception with three arguments,
falling back to two arguments for compatibility. Note that using None
for the headers follows what was done in the upstream commit,
ddd437a7c (Export headers in GithubException).
Closes #5602.